feat(scummtr): Fix text extraction resource for German releases of Indy3 (#58) #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dy3 (#58) This is an original bug in the official German releases, some German Eszett characters were misencoded as \255 instead of \225, triggering the "special espace sequence" code. The following script lines are impacted: [023:SC#0108]^irgendwo hier im Schlo\255. [028:SC#0071]Nicht so schnell! Woher weiß ich, da\255 Sie kein Spion sind? Just ignore the \255 and replace it with the inteded \225, on the fly. This unbreaks exporting/importing the text with ScummTR. See also the related original ScummVM bugs: https://bugs.scummvm.org/ticket/1675 https://bugs.scummvm.org/ticket/2715 Thanks to @gabberhead for reporting the issue.
|
Commit 977ad42 was necessary too in order to fix all instances of the bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should hopefully fix the bug reported in #58
Tested against an original DOS VGA German release.