Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/examples: various improvements #157

Merged
merged 12 commits into from
Mar 4, 2024
Merged

test/examples: various improvements #157

merged 12 commits into from
Mar 4, 2024

Conversation

G4Vi
Copy link
Contributor

@G4Vi G4Vi commented Feb 24, 2024

  • Fix broken module kitchensink.c
  • Add reactor module and example
  • Add component reactor and example
  • fix component build by pinning cli tool versions

Copy link
Contributor

@chrisdickinson chrisdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -0,0 +1,27 @@
package dylibso:observe;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth .gitignore-ing this file since we generate it via the Makefile?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was needed for cargo test to pass. I reordered building wit / copying it to there so it doesn't need to be in source control.

@G4Vi G4Vi requested a review from chrisdickinson March 4, 2024 20:28
Copy link
Contributor

@chrisdickinson chrisdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@G4Vi G4Vi merged commit 4b1ff53 into main Mar 4, 2024
6 checks passed
@G4Vi G4Vi deleted the test-examples-improvements branch March 4, 2024 20:58
@G4Vi G4Vi mentioned this pull request Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants