This repository has been archived by the owner on Apr 30, 2024. It is now read-only.
🎨 Improved templates.py structure
#5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trymzet
suggested changes
Jul 4, 2023
Comment on lines
+60
to
+64
| Saves the file name from which the deployment was created in a list under the parameter "tags". | ||
| The file name is necessary in the tags to automatically delete the deployment based on that information, | ||
| as Prefect does not store any information about the file from which the deployment originated. | ||
| Automatic deletion is performed using Azure Pipeline "Prefect automatic deployments", which fetches the script during execution | ||
| from the following repository. https://github.com/dyvenia/nesso-starter-project/blob/main/.github/scripts/prefect_deployments.py |
There was a problem hiding this comment.
I think from this script, all we know is this adds a filename tag for use by eg. CI/CD pipelines. There should be no reference to any particular pipeline, but it makes sense to say this feature is used by the prefect_deployments.py script.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An amendment has been made by adding a tag to each flow. This change is crucial because adding a tag with the file name is necessary for identifying the deployment during deletion.