Skip to content

Commit

Permalink
Merge pull request #21 from e-line-websolutions/restore-set-reverseFi…
Browse files Browse the repository at this point in the history
…eld-issue

Restore set reverse field issue
  • Loading branch information
mjhagen authored May 20, 2021
2 parents bb3e66d + 7cf9115 commit 98becce
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 0 deletions.
3 changes: 3 additions & 0 deletions base.cfc
Original file line number Diff line number Diff line change
Expand Up @@ -987,6 +987,9 @@ component mappedSuperClass=true cacheuse="transactional" defaultSort="sortorder"
var reverseField = objectToOverride.getReverseField( reverseCFCLookup, property.inverseJoinColumn );
queueInstruction( objectToOverride, "remove#reverseField#", this );
arrayAppend( result, "#objectToOverride.getName()#.remove#reverseField#(#this.getName()#)" );
} else {
var reverseField = objectToOverride.getReverseField( reverseCFCLookup, property.fkcolumn, false );
queueInstruction( objectToOverride, "set#reverseField#", "null" );
}

queueInstruction( this, "remove#propertyName( property )#", objectToOverride );
Expand Down
19 changes: 19 additions & 0 deletions tests/specs/default.cfc
Original file line number Diff line number Diff line change
Expand Up @@ -285,6 +285,25 @@ component extends="testbox.system.basespec" {
expect( savedentitiesinsubfolder[ 1 ].getid() ).tobe( third.getid() );
} );

it( 'expects save( {set_data=[]}) to clear all items in data', function() {
transaction {
var first = entityNew( 'other' ).save( { name = 'first' } );
var second = entityNew( 'other' ).save( { name = 'second' } );
variables.obj.save( { 'entitiesinsubfolder' = [ first, second ] } );
}

expect( variables.obj.getEntitiesinsubfolder() ).toHaveLength( 2 );

transaction {
variables.obj.save( { 'entitiesinsubfolder' = [] } );
}

expect( variables.obj.getEntitiesinsubfolder() ).toHaveLength( 0 );

// expect( entityLoad( 'other', { name = 'first' } ) ).toBeEmpty();
// expect( entityLoad( 'other', { name = 'second' } ) ).toBeEmpty();
} );

it( 'expects remove to work', function() {
transaction {
var multiple_1 = entityNew( 'multiple' ).save();
Expand Down

0 comments on commit 98becce

Please sign in to comment.