Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unbalanced result columns #2374

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Fix unbalanced result columns #2374

wants to merge 4 commits into from

Conversation

jkupka
Copy link
Collaborator

@jkupka jkupka commented Aug 12, 2024

This PR fixes two issues with unbalanced result columns:

  1. columns 'p_c_from_mw' and 'loading_percent' were missing in 'res_line_3ph"
  2. unbalanced loss columns didn't follow naming conventions (e.g. 'p_a_l_mw' should be 'pl_a_mw'). It's already correct in the documentation but not the code:
    grafik

Issue 2) is probably a breaking change if something relies on those unbalanced loss columns.

@jkupka jkupka requested a review from SteffenMeinecke August 12, 2024 20:05
@vogt31337
Copy link
Contributor

@jkupka a lot of tests failed, could you please fix 'em and provide an entry for the changelog?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteffenMeinecke SteffenMeinecke Awaiting requested review from SteffenMeinecke

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkupka @vogt31337