Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add optional-dependencies julia #2420

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

yasirroni
Copy link
Contributor

No description provided.

@vogt31337
Copy link
Contributor

@yasirroni Thank you for your interest in this work. Could you provide more detail on why we should add this dependency? Are you actively using the julia parts of this project?

@yasirroni
Copy link
Contributor Author

You can't say that I'm actively used. I just writing a benchmark and pandapower happen to be one of it. I will bench both manual approach accessing PowerMoodels and PowerModels via pandapower.

I'm only interested to fix bug in #2409 since PGLib will be one of the bench and I don't want pandapower to be not compatible.

@vogt31337
Copy link
Contributor

@yasirroni that is really interesting, thanks for helping fix this bug. But I don't understand why pandapower needs to be directly depending on julia? Maybe it would be better to introduce an OPF field for the packages, so that these packages get installed when, a user explicitly wants to do some OPF related research.

@yasirroni
Copy link
Contributor Author

@yasirroni that is really interesting, thanks for helping fix this bug. But I don't understand why pandapower needs to be directly depending on julia? Maybe it would be better to introduce an OPF field for the packages, so that these packages get installed when, a user explicitly wants to do some OPF related research.

That is already in extras (optional) dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants