ESP32 AudioOutputULP fixes #579
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CONFIG_IDF_TARGET_ESP32 is not yet defined before #include "AudioOutputULP.h"
Gifford47
approved these changes
Nov 11, 2022
Gifford47
approved these changes
Nov 11, 2022
Gifford47
approved these changes
Nov 11, 2022
Gifford47
approved these changes
Nov 11, 2022
On ESP32S2 it compiles, but no audio is coming out On ESP32S3 DAC is not supported
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ULP didn't work anymore on ESP32 because of a stupid mistake:
CONFIG_IDF_TARGET_ESP32 is only defined after #include"AudioOutputULP.h" ! So the ESP32 code was actually skipped
Also a small fix for stereo ULP support: stereo was in reality also mono