AudioOutputPWM: fixed constructor for custom out-pin, added amplification #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added PWMAudio to initializer list, added amplification
hackerceo
pushed a commit
to hackerceo/ESP8266Audio
that referenced
this pull request
Nov 1, 2024
Co-authored-by: RASMUSSEN Joern <joern.rasmussen-ext@hexagon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hej Earle,
This PR adds PWMAudio to initializer list, which allows changing output pin per constructor.
Furthermore I added amplification.
There is a defaults-mismatch/-ambiguity regarding mono/stereo. I might take a look into it but that most likely requires some discussion..