address comments

R/data_arrange.R

@@ -42,7 +42,7 @@ data_arrange.default <- function(data, select = NULL, safe = TRUE) {
   select <- gsub("^-", "", select)
 
   # check for variables that are not in data
-  dont_exist <- select[which(!select %in% names(data))]
+  dont_exist <- setdiff(select, colnames(data))
 
   if (length(dont_exist) > 0) {
     if (safe) {

R/rescale_weights.R

@@ -140,6 +140,8 @@ rescale_weights <- function(data,
                             probability_weights = NULL,
                             nest = FALSE,
                             method = "carle") {
+  method <- insight::validate_argument(method, c("carle", "kish"))
+
   if (inherits(by, "formula")) {
     by <- all.vars(by)
   }

tests/testthat/test-rescale_weights.R

@@ -89,6 +89,14 @@ test_that("rescale_weights errors and warnings", {
     ),
     regex = "is not used"
   )
+  expect_warning(
+    rescale_weights(
+      data = head(nhanes_sample, n = 30),
+      probability_weights = "WTINT2YR",
+      method = "dish"
+    ),
+    regex = "Invalid option for argument"
+  )
 
   nhanes_sample$rescaled_weights_a <- 1
   expect_warning(