Replace stream::select to stream_select! #414
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
futures::stream::select will poll streams in a round-robin fashion, which means one stream can be blocked if the other stream does not have item ready. It replaces select to stream_select which just poll stream whichever comes first. Reference: https://docs.rs/futures/latest/futures/stream/fn.select.html Reference: https://docs.rs/futures/latest/futures/macro.stream_select.html
blmarket
commented
Feb 25, 2024
| @@ -27,7 +29,7 @@ const MESSAGE_QUEUE_SIZE: usize = 100; | |||
| /// This socket handles the server-to-client half of the bidirectional communication stream. | |||
| pub trait Loopback { | |||
| /// Yields a stream of pending server-to-client requests. | |||
| type RequestStream: Stream<Item = Request>; | |||
| type RequestStream: Stream<Item = Request> + Unpin; | |||
There was a problem hiding this comment.
Note: Breaking change, but it still pass the unit tests + works with stdio. Required by stream_select!
|
3 months with no update, so ping here. will ping again next year. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
futures::stream::selectwill poll streams in a round-robin fashion, which means one stream can be blocked if the other stream does not have item ready.It replaces select to
futures::stream_select!which just poll stream whichever comes first.Reference: https://docs.rs/futures/latest/futures/stream/fn.select.html
Reference: https://docs.rs/futures/latest/futures/macro.stream_select.html
Note: current
masterbranch is broken and need to apply #406 first.Demo of bug: https://github.com/blmarket/tower-lsp/blob/buggy-example/tests/buggy.rs
Without patch - it hangs if there are 3 or more logs. It runs okay if we comment out 1 or 2 logs.
With patch - it run okay regardless of number of logs