Actually exit after receiving exit notification
#428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Happy to add a test if this approach looks reasonable and you can point me in the right direction for how to write the test! |
jfly
added a commit
to jfly/harper
that referenced
this pull request
Oct 25, 2024
This version of `tower-lsp` includes ebkalderon/tower-lsp#428, which fixes elijah-potter#139
jfly
added a commit
to jfly/harper
that referenced
this pull request
Oct 26, 2024
This version of `tower-lsp` includes ebkalderon/tower-lsp#428, which fixes elijah-potter#139
|
@ebkalderon It would be great to get this merged in. Harper has an issue related to this, as well as a number of other LSPs. Thank you so much for your work on this project, a huge number of language servers wouldn't be possible without it. |
jfly
added a commit
to jfly/harper
that referenced
this pull request
Oct 27, 2024
This version of `tower-lsp` includes ebkalderon/tower-lsp#428, which fixes elijah-potter#139
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #399 and #424.
Note: this will not compile until #406 is merged.