Fix broken zero pad implementation causing corrupted ciphertext #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you think we need additional IsOnCurve check after ScalarMult? |
|
On further analysis I don't think it is necessary, it must have been a leftover from the investigation into the root cause. I've dropped that commit. |
|
@gmaiainc very nice catch! Thank you for the contribution! I will prepare a release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #86, which was mainly caused by a broken zeroPad function as well as equally buggy equivalent code present in publickey.go. An additional on-curve check was also added, as well as a benchmark test that would have made the bug easier to identify.