Fix the issue 333 (#336)

* Fix bugs w.r.t. test-engine * Fix for GH issue 333 * Fix for GH issue 333
eclipse-aaspe · Jul 22, 2024 · 10dda2c · 10dda2c
1 parent e1fbe6c
commit 10dda2c
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 1 deletion.
diff --git a/src/IO.Swagger.Lib.V3/Exceptions/InvalidPaginationParameterException.cs b/src/IO.Swagger.Lib.V3/Exceptions/InvalidPaginationParameterException.cs
@@ -0,0 +1,12 @@
+using System;
+
+namespace IO.Swagger.Lib.V3.Exceptions
+{
+    public class InvalidPaginationParameterException : Exception
+    {
+        public InvalidPaginationParameterException(string paramName, int? value) : base($"Invalid pagination parameter {paramName} value = {value}.")
+        {
+
+        }
+    }
+}
diff --git a/src/IO.Swagger.Lib.V3/Middleware/ExceptionMiddleware.cs b/src/IO.Swagger.Lib.V3/Middleware/ExceptionMiddleware.cs
@@ -88,6 +88,7 @@ private async Task HandleExceptionAsync(HttpContext context, Exception exception
                         message.MessageType = MessageTypeEnum.Error;
                         break;
                     }
+                case InvalidPaginationParameterException:
                 case Jsonization.Exception:
                 case InvalidIdShortPathException:
                 case InvalidUpdateResourceException:

diff --git a/src/IO.Swagger.Lib.V3/Models/PaginationParameters.cs b/src/IO.Swagger.Lib.V3/Models/PaginationParameters.cs
@@ -1,4 +1,6 @@
-namespace IO.Swagger.Models;
+namespace IO.Swagger.Models;
+
+using IO.Swagger.Lib.V3.Exceptions;
 
 public class PaginationParameters
 {
@@ -13,6 +15,10 @@ public PaginationParameters(string? cursor, int? limit)
         _cursor = string.IsNullOrEmpty(cursor) || !int.TryParse(cursor, out var parsedCursor) ? 0 : parsedCursor;
 
         // Set limit to provided value or default to MaxResultSize
+        if(limit < 0)
+        {
+            throw new InvalidPaginationParameterException("Limit", limit);
+        }
         _limit = limit ?? MaxResultSize;
     }