TimeStamp to TimeStampTree #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge with remote branch aasx-server/main
Merge with remote branch
Merge with main
Merge idta main
Merge pxc dev-sme
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+380
to
+382
| (sme.TValue == string.Empty || sme.TValue == null) && | ||
| (!withSME || (sme.SemanticId != null && sme.SemanticId.Equals(semanticId))) && | ||
| (!withDiff || sme.TimeStampTree.CompareTo(diff) > 0)) |
Check notice
Code scanning / CodeQL
Complex condition Note
| @@ -326,7 +326,7 @@ | |||
| { | |||
| smId = identifier, | |||
| url = $"{ExternalBlazor}/submodels/{Base64UrlEncoder.Encode(identifier)}", | |||
| timeStamp = TimeStamp.TimeStamp.DateTimeToString(sm.TimeStamp) | |||
| timeStampTree = TimeStamp.TimeStamp.DateTimeToString(sm.TimeStampTree) | |||
Check warning
Code scanning / CodeQL
Dereferenced variable may be null Warning
Freezor
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change from using the TimeStamp to TimeStampTree in PageRetriever and Query.
Please delete options that are not relevant.
Checklist: