Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs w.r.t. test-engine #332

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Conversation

juileetikekar
Copy link
Contributor

@juileetikekar juileetikekar commented Jul 18, 2024

Description

This PR consists of fixes for the bugs found during API validation with aas-test-engine.

Motivation and Context

This change is required for the correct implementation of the APIs

Fixes # (issue)

  1. In case of POST APIs, if the request body has serialization issues, the server now sends BadRequest (earlier Internal Server Error).
  2. In case of API GET "/shells/$reference", if there are no shells present, server used to throw InternalServerError, due to null pointer exception. The issue has been now fixed. The server in this case now return empty Result.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

The fixes are tested manually with the help of in-buit swagger-ui and with aas-test-engine.

Screenshots (if appropriate):

Checklist:

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@juileetikekar juileetikekar merged commit e1fbe6c into main Jul 19, 2024
17 checks passed
@Freezor Freezor added the bug Something isn't working label Jul 31, 2024
AlexanderWollbrink pushed a commit that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants