-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add client progress for delegate commands #2821
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Hope Hadfield <hhadfiel@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works, but there's a problem.
This behaviour seems similar to what's described in redhat-developer/vscode-java#3249 so maybe there's an existing bug in the progress report where some tasks don't received an .end
notification
CC : @testforstephen So I looked at one of the progress messages that hang :
and looked earlier at what kind of messages fall under
Looks to me like this is called by https://github.com/microsoft/vscode-java-test/blob/main/src/controller/testController.ts#L44-L67 whenever There's even an error from the delegate call on the JDT-LS side :
I want to merge this, but we should really wait to confirm that the delegates commands are well behaved and don't result in report error, which result in spinning forever. |
Fixes #1186