-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Fastlane for F-Droid #24
Conversation
Closes: eclipse-kuksa#12 Signed-off-by: Andre Weber <andre.weber3@etas.com>
.editorconfig
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also to review:
org.eclipse.kuksa.companion.yaml:
Categories:
- Connectivity
License: Apache-2.0
WebSite: https://eclipse-kuksa.github.io/kuksa-website
SourceCode: https://github.com/eclipse-kuksa/kuksa-android-companion
IssueTracker: https://github.com/eclipse-kuksa/kuksa-android-companion/issues
Changelog: https://github.com/eclipse-kuksa/kuksa-android-companion/blob/main/CHANGELOG.md
RepoType: 'git'
Repo: https://github.com/eclipse-kuksa/kuksa-android-companion.git
Builds:
- gradle: yes
subdir: app
output: app/build/outputs/apk/release/app-release-unsigned.apk
AutoUpdateMode: Version
UpdateCheckMode: Tags release/v[\d.]+
UpdateCheckData: versioncode.txt|(\d+)|version.txt|([\d.]+)
CurrentVersion: 0.1.0
CurrentVersionCode: 10000100
This file will be used when creating the PR for the Data Repository. Please check carefully - even though I still think the maintainer of the F-Droid Repo will support in case of issues / errors.
More Info here: https://f-droid.org/docs/Build_Metadata_Reference
Sample Files: https://gitlab.com/fdroid/fdroiddata
To reduce redundancy I did not specify info, which could be retrieved by the app itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also compared it with the example here: https://gitlab.com/fdroid/fdroiddata/-/blob/master/metadata/org.fdroid.fdroid.yml
LGTM
More Info about FastLane: To keep redundancy low I tried to omit data, which can be retrieved from the app itself like app name and icon |
.editorconfig
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also compared it with the example here: https://gitlab.com/fdroid/fdroiddata/-/blob/master/metadata/org.fdroid.fdroid.yml
LGTM
LGTM |
@SebastianSchildt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Texts look fine, Icons seem a "big thing" on Android just looking at the number of generated files, and Gihtub does not now that webp ist actually an image format :)
tldr; lgtm
Closes: #12
Closes: #14