Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fastlane for F-Droid #24

Merged
merged 6 commits into from
Nov 23, 2023

Conversation

wba2hi
Copy link
Contributor

@wba2hi wba2hi commented Nov 23, 2023

Closes: #12
Closes: #14

.editorconfig Outdated
Copy link
Contributor Author

@wba2hi wba2hi Nov 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also to review:

org.eclipse.kuksa.companion.yaml:

Categories:
  - Connectivity

License: Apache-2.0

WebSite: https://eclipse-kuksa.github.io/kuksa-website
SourceCode: https://github.com/eclipse-kuksa/kuksa-android-companion
IssueTracker: https://github.com/eclipse-kuksa/kuksa-android-companion/issues
Changelog: https://github.com/eclipse-kuksa/kuksa-android-companion/blob/main/CHANGELOG.md

RepoType: 'git'
Repo: https://github.com/eclipse-kuksa/kuksa-android-companion.git

Builds:
  - gradle: yes
    subdir: app
    output: app/build/outputs/apk/release/app-release-unsigned.apk

AutoUpdateMode: Version
UpdateCheckMode: Tags release/v[\d.]+
UpdateCheckData: versioncode.txt|(\d+)|version.txt|([\d.]+)
CurrentVersion: 0.1.0
CurrentVersionCode: 10000100

This file will be used when creating the PR for the Data Repository. Please check carefully - even though I still think the maintainer of the F-Droid Repo will support in case of issues / errors.

More Info here: https://f-droid.org/docs/Build_Metadata_Reference
Sample Files: https://gitlab.com/fdroid/fdroiddata

To reduce redundancy I did not specify info, which could be retrieved by the app itself.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wba2hi
Copy link
Contributor Author

wba2hi commented Nov 23, 2023

More Info about FastLane:

To keep redundancy low I tried to omit data, which can be retrieved from the app itself like app name and icon

.editorconfig Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fastlane/metadata/android/en-US/full_description.txt Outdated Show resolved Hide resolved
fastlane/metadata/android/en-US/full_description.txt Outdated Show resolved Hide resolved
@Chrylo
Copy link
Contributor

Chrylo commented Nov 23, 2023

LGTM

@wba2hi
Copy link
Contributor Author

wba2hi commented Nov 23, 2023

@SebastianSchildt
PR can be merged. If you find the time, please also do a short sanity / consistency check on the texts

Copy link
Contributor

@SebastianSchildt SebastianSchildt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Texts look fine, Icons seem a "big thing" on Android just looking at the number of generated files, and Gihtub does not now that webp ist actually an image format :)

tldr; lgtm

@SebastianSchildt SebastianSchildt merged commit 36a76ba into eclipse-kuksa:main Nov 23, 2023
5 checks passed
@erikbosch erikbosch deleted the feature-12 branch October 31, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add App Icon to Companion App F-Droid: Add Fastlane File Structure for App Description
3 participants