feature: Improve Design of Settings Screen #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- move Composables to separate files with Preview - use a DialogView when changing values of EditableTextSettings - extract common variables for common attributes like textSize or paddings - make the whole SettingElement clickable - improve FileSelectorSetting -- add an "upload" image to the end -- don't show "Select Certificate" when TLS is disabled -- output the filename of the selected file instead of the cryptic uri path or an empty text when no certificate has been selected before close: eclipse-kuksa#56
e.g. when using 10.0.23 instead of 10.0.0.23
|
Can we configure the port input keyboard as a number keyboard? |
|
Design looks good to me :) Good job |
Good Idea! Done |
wba2hi
commented
Feb 14, 2024
app/src/main/kotlin/org/eclipse/kuksa/companion/feature/settings/view/EditableTextSetting.kt
Show resolved
Hide resolved
|
LGTM |
Chrylo
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes a crash which occurs when an invalid IP address is provided (e.g. 10.0.23 instead of 10.0.0.23)
or paddings
-- add an "upload" image to the end
-- don't show "Select Certificate" when TLS is disabled
-- output the filename of the selected file instead of the cryptic
uri path or an empty text when no certificate has been selected
before
close: #56