Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate grammar comments #1335

Merged
merged 3 commits into from
Feb 2, 2024
Merged

Generate grammar comments #1335

merged 3 commits into from
Feb 2, 2024

Conversation

msujew
Copy link
Member

@msujew msujew commented Jan 8, 2024

In #1095 we actually forgot to enable the serializer to also serialize the comments. This change rectifies that oversight. See also #1333.

@msujew msujew added the cli CLI related issue label Jan 8, 2024
@msujew msujew added this to the v3.0.0 milestone Jan 8, 2024
@msujew msujew force-pushed the msujew/generate-grammar-comments branch from 3caa6bd to e1c45e6 Compare January 8, 2024 17:00
@msujew msujew force-pushed the msujew/generate-grammar-comments branch from 3b929a5 to d181da3 Compare January 9, 2024 14:07
Copy link
Contributor

@sailingKieler sailingKieler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. However, I would prefer to have a dedicated unit test "formally" documenting the feature in addition to the 'integration' test in the domain model language.

* This program and the accompanying materials are made available under the
* terms of the MIT License, which is available in the project root.
******************************************************************************/
// ******************************************************************************
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this comment formatting is changed to be not recognized as JSdoc, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct 👍

Copy link
Contributor

@sailingKieler sailingKieler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@msujew msujew merged commit 1f5d124 into main Feb 2, 2024
5 checks passed
@msujew msujew deleted the msujew/generate-grammar-comments branch February 2, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli CLI related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants