Expose workspace folders via a readonly getter #1679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Specifically, the reason I needed this is these commits: https://github.com/SnakeskinTpl/language-tools/pull/8/files/7f54af2eaffee9085209975609521fe0db86b9b9..98e2571ba34e1dcbf1ad30412f8752cd5c160a67 If there is a better way to implement multi-root workspace support (with separate config files in each) using existing APIs, please let me know. |
msujew
approved these changes
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I could not figure out how to get information about the current workspace roots (important in a multi-root workspace), so I added a getter for it.
If we want to enforce that it is only accessed after
readyis resolved, we could havereadyresolve to it and remove the getter.