Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Checkbox Coloring on Dialog when using FormToolkit #2474

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marcushoepfner
Copy link
Contributor

Issue #416

@marcushoepfner
Copy link
Contributor Author

Before:
Screenshot 2024-10-31 at 14 22 56

After:
Screenshot 2024-10-31 at 14 23 55

But unfortunately also influences:
Screenshot 2024-10-31 at 14 31 09

So there is a bit more to fix.
@BeckerWdf, can you help here?

Copy link
Contributor

Test Results

 1 821 files  ±0   1 821 suites  ±0   1h 52m 34s ⏱️ - 1m 51s
 7 724 tests ±0   7 496 ✅ +1  228 💤 ±0  0 ❌  - 1 
24 333 runs  ±0  23 586 ✅ +1  747 💤 ±0  0 ❌  - 1 

Results for commit db20643. ± Comparison against base commit 83c128c.

@vogella
Copy link
Contributor

vogella commented Nov 5, 2024

Could you use the shell style for selection?

/* Style for SWT.PUSH buttons in dialogs /
Shell[style
=SWT.APPLICATION_MODAL] Button[type=SWT.PUSH] {
background-color: #007ACC; /* Change to your desired background color */
}

@@ -48,7 +48,7 @@ Tree[swt-lines-visible=true] {
background-color: unset;
}

Button {
Button[style~='SWT.PUSH'] {
background-color: unset;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could also try to use "inherit" instead of "unset"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants