Find/replace overlay: allow pasting into replace input field #2509 #2513
Conversation
This PR does not completely fix #2509. It just fixes pasting into the replace field for non-multipage-editors (for which I added an additional comment to #2509). Probably I should have opened a separate issue for that, but I first though they are highly related, as they are all about pasting into the overlay (and using other shortcuts). |
HeikoKlare
force-pushed
the
issue-2509-1
branch
from
ff1b790
to
dfa5bd5
Compare
|
In my opinion, this should be fixed for the upcoming release, as it is quite annoying to not be able to use common shortcuts to cut, copy, paste etc. in the replace input field of the find/replace overlay. @akurtakov @vogella may I ask for the PMC approval of one of you (or any other PMC member) to still merge this? |
|
I haven't reviewed the actual code change nor tested it but the issue looks important enough to worth PMC +1 from me for RC1. |
|
Code change looks good. Please push when verifications succeed. |
…platform#2509 While actions of the target editor are properly deactivated when the find input field of the FindReplaceOverlay has focus, the same does not happen for the replace input field. In consequence, for example, you cannot paste clipboard content into the replace input field via the according keyboard shortcut (CTRL+V). With this change, the functionality to deactivate target editor actions is also applied when the the replace input field has focus, in addition to the find input field. Contributes to eclipse-platform#2509
HeikoKlare
force-pushed
the
issue-2509-1
branch
from
dfa5bd5
to
7e9c897
Compare
|
Thank you! |
While actions of the target editor are properly deactivated when the find input field of the FindReplaceOverlay has focus, the same does not happen for the replace input field. In consequence, for example, you cannot paste clipboard content into the replace input field via the according keyboard shortcut (CTRL+V).
With this change, the functionality to deactivate target editor actions is also applied when the the replace input field has focus, in addition to the find input field.
Contributes to #2509
Demo
Behavior before fix:
Behavior after fix:
