-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify nested property structure #613
Conversation
|
fixed #612 Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
src/docs/blueprint_documentation.md
Outdated
|
||
To change the application name, open the file and locate the following nested structure: | ||
|
||
- `theia` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if it might look nicer if we nested this in a ```json block, like they did under "Customizing the Welcome Page": https://eclipse-theia.github.io/theia-website-previews/pr-previews/pr-613/docs/blueprint_documentation/#application-window-title
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you mean with ```json?
I do not see the example you mean under "welcome page"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, under the welcome page we have:
bind(TheiaBlueprintGettingStartedWidget).toSelf();
bind(WidgetFactory).toDynamicValue(context => ({
id: GettingStartedWidget.ID,
createWidget: () => context.container.get<TheiaBlueprintGettingStartedWidget>(TheiaBlueprintGettingStartedWidget),
})).inSingletonScope();
I think something like this would be easier to understand and would look nicer on the page:
"theia": {
"frontend": {
"config": {
"applicationName": "Theia IDE",
},
},
},
Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
fixed #612