Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify nested property structure #613

Merged
merged 2 commits into from
Oct 7, 2024
Merged

Clarify nested property structure #613

merged 2 commits into from
Oct 7, 2024

Conversation

JonasHelming
Copy link
Contributor

fixed #612

Copy link

github-actions bot commented Oct 4, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-10-07 12:04 UTC

fixed #612

Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>

To change the application name, open the file and locate the following nested structure:

- `theia`
Copy link
Contributor

@jfaltermeier jfaltermeier Oct 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it might look nicer if we nested this in a ```json block, like they did under "Customizing the Welcome Page": https://eclipse-theia.github.io/theia-website-previews/pr-previews/pr-613/docs/blueprint_documentation/#application-window-title

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you mean with ```json?
I do not see the example you mean under "welcome page"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, under the welcome page we have:

    bind(TheiaBlueprintGettingStartedWidget).toSelf();
    bind(WidgetFactory).toDynamicValue(context => ({
        id: GettingStartedWidget.ID,
        createWidget: () => context.container.get<TheiaBlueprintGettingStartedWidget>(TheiaBlueprintGettingStartedWidget),
    })).inSingletonScope();

I think something like this would be easier to understand and would look nicer on the page:

  "theia": {
    "frontend": {
      "config": {
        "applicationName": "Theia IDE",
      },
    },
  },

Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
@JonasHelming JonasHelming merged commit e13e0e2 into master Oct 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: describe that applicationName is nested
2 participants