Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable code scanning default setup #3

Closed
wants to merge 1 commit into from

Conversation

sebthom
Copy link
Member

@sebthom sebthom commented Nov 4, 2024

This is required to run custom codeql workflows

Signed-off-by: Sebastian Thomschke <sebthom@users.noreply.github.com>
@sebthom sebthom requested a review from a team as a code owner November 4, 2024 21:27
Copy link

This is your friendly self-service bot.

Thank you for raising a pull request to update the configuration of your GitHub organization.
You can manually add reviewers to this PR to eventually enable auto-merging.

The following conditions need to fulfilled for auto-merging to be available:

  • valid configuration
  • approved by a project lead
  • does not require any secrets
  • does not update settings only accessible via the GitHub Web UI
  • does not remove any resource
Otterdog commands and options

You can trigger otterdog actions by commenting on this PR:

  • /otterdog team-info checks the team / org membership for the PR author
  • /otterdog validate validates the configuration change
  • /otterdog validate info validates the configuration change, printing also validation infos
  • /otterdog check-sync checks if the base ref is in sync with live settings
  • /otterdog merge merges and applies the changes if the PR is eligible for auto-merging (only accessible for the author)
  • /otterdog done notifies the self-service bot that a required manual apply operation has been performed (only accessible for members of the admin team)
  • /otterdog apply re-apply a previously failed attempt (only accessible for members of the admin team)

Copy link

This is your friendly self-service bot.

The author (sebthom) of this PR is associated with this organization in the role of MEMBER.

Additionally, sebthom is a member of the following teams:

Copy link

This is your friendly self-service bot.
Please find below the validation of the requested configuration changes:

Diff for 3c35c5d
Organization technology.tm4e[id=eclipse-tm4e]
  there have been 1 validation infos, enable verbose output with '-v' to to display them.

  
!   repository[name="tm4e"] {
!     code_scanning_default_setup_enabled = true -> false
!   }
  
  Plan: 0 to add, 1 to change, 0 to delete.

Copy link

This is your friendly self-service bot. The current configuration is out-of-sync with the live settings:

Diff to live settings
Organization technology.tm4e[id=eclipse-tm4e]
  there have been 1 validation infos, enable verbose output with '-v' to to display them.

  
!   repository[name="tm4e"] {
!     code_scanning_default_languages = [
-      javascript
-      typescript
!     ]
!   }
  
  Plan: 0 to add, 1 to change, 0 to delete.

The current configuration needs to be updated to reflect the live settings otherwise they would be overwritten when this PR gets merged.

cc @eclipse-tm4e/eclipsefdn-security

cc @eclipse-tm4e/eclipsefdn-releng

@sebthom
Copy link
Member Author

sebthom commented Nov 4, 2024

@netomi as far as I understand I need to disable the code scanning default setup for my PR with a custom codeql workflow to succeed. eclipse-tm4e/tm4e#826

@netomi
Copy link
Contributor

netomi commented Nov 4, 2024

I disabled codeql default setup manually and update the config already. Something has changed from GitHub side as this is not working at all anymore. Sorry for the inconvenience, going to take a look at the configuration, but with the custom workflow it should work reliable afaict.

@netomi netomi closed this Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants