Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove knowledge about AppManifest structure #140

Merged
merged 3 commits into from
Aug 16, 2023
Merged

Conversation

doosuu
Copy link
Member

@doosuu doosuu commented Jul 24, 2023

CLI parses the AppManifest but does not need to care about the actual structure of the manifest. Therefore the structural correct parsing is removed from the responsibility of the CLI with this PR (validity of JSON is still checked).

@doosuu doosuu force-pushed the no-app-manifest-knowledge branch 2 times, most recently from 19092c1 to aee0786 Compare July 25, 2023 10:36
@doosuu doosuu force-pushed the no-app-manifest-knowledge branch 2 times, most recently from 6db116c to 11a59bc Compare August 3, 2023 12:33
@github-actions
Copy link

github-actions bot commented Aug 3, 2023

File Coverage Lines Branches
All files 76% 86% 67%
src/commands/exec/index.ts 79% 92% 66%
src/commands/init/index.ts 76% 87% 65%
src/commands/package/index.ts 88% 95% 80%
src/modules/component.ts 84% 96% 73%
src/modules/exec.ts 58% 65% 51%
src/modules/package-downloader.ts 85% 96% 75%
src/modules/package.ts 91% 92% 90%
src/modules/project-cache.ts 83% 96% 71%
src/modules/project-config.ts 82% 91% 73%
src/modules/semver.ts 50% 64% 37%
src/modules/setup.ts 24% 33% 15%
src/modules/variables.ts 87% 94% 80%

Minimum allowed coverage is 80%

Generated by 🐒 cobertura-action against 64837cd

Copy link
Contributor

@dennismeister93 dennismeister93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@doosuu doosuu merged commit 8cc3094 into main Aug 16, 2023
8 checks passed
@doosuu doosuu deleted the no-app-manifest-knowledge branch August 16, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants