Improvement: Vehicle Model generator as module integration #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @mml5bg , if there is no intention to merge this PR, please mark it as draft or delete it. |
doosuu
reviewed
Aug 19, 2023
| @@ -104,7 +94,7 @@ def install_model_if_required(language: str, model_path: str) -> None: | |||
| model_path (str): The path where the generated model is stored. | |||
| """ | |||
| if language == "python": | |||
| subprocess.check_call([sys.executable, "-m", "pip", "install", model_path]) | |||
| subprocess.check_call(["sys.executable", "-m", "pip", "install", model_path]) | |||
There was a problem hiding this comment.
Why is sys.executable quoted now? That way its just a string literal and not a variable which is being resolved. I doubt this change is runnable. Have you tested it?
|
@mml5bg Can we close this one or is it still needed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.