Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pantaris integration #39

Merged
merged 7 commits into from
Sep 14, 2023
Merged

Pantaris integration #39

merged 7 commits into from
Sep 14, 2023

Conversation

MP91
Copy link
Contributor

@MP91 MP91 commented Sep 1, 2023 •
edited
Loading

  • Removed velocitas_lib from this and adapted all packages to use the new repo
  • added desired_state_generator
  • renamed packages to fix mypy errors

@github-actions
Copy link

github-actions bot commented Sep 1, 2023 •
edited
Loading

File Coverage Lines Branches
All files 20% 26% 14% ❌
desired_state_generator/src/gen_desired_state.py 36% 41% 32% ❌
runtime_k3d/src/app_deployment/build_vehicleapp.py 0% 0% 0% ❌
runtime_k3d/src/app_deployment/deploy_vehicleapp.py 0% 0% 0% ❌
runtime_k3d/src/runtime/controlplane.py 0% 0% 0% ❌
runtime_k3d/src/runtime/runtime-down.py 0% 0% 0% ❌
runtime_k3d/src/runtime/runtime-up.py 0% 0% 0% ❌
runtime_k3d/src/runtime/runtime.py 0% 0% 0% ❌
runtime_k3d/src/runtime/deployment/gen_helm.py 29% 39% 19% ❌
runtime_k3d/src/runtime/deployment/gen_podspec.py 44% 54% 35% ❌
runtime_k3d/src/runtime/deployment/lib.py 93% 87% 100% ✅
runtime_kanto/src/app_deployment/build_vehicleapp.py 0% 0% 0% ❌
runtime_kanto/src/app_deployment/deploy_vehicleapp.py 0% 0% 0% ❌
runtime_kanto/src/runtime/controlplane_kanto.py 0% 0% 0% ❌
runtime_kanto/src/runtime/runtime_down.py 0% 0% 0% ❌
runtime_kanto/src/runtime/runtime_kanto.py 0% 0% 0% ❌
runtime_kanto/src/runtime/runtime_up.py 0% 0% 0% ❌
runtime_local/src/local_lib.py 22% 22% 0% ❌
runtime_local/src/run-dapr-sidecar.py 0% 0% 0% ❌
runtime_local/src/run-vehicle-app.py 0% 0% 0% ❌
runtime_local/src/run_service.py 30% 42% 18% ❌
runtime_local/src/runtime-up.py 0% 0% 0% ❌

Minimum allowed coverage is 80%

Generated by 🐒 cobertura-action against 9c23909

@MP91 MP91 marked this pull request as ready for review September 7, 2023 11:10
@MP91
add desired state generator
0ad1ebb 
- rename packages to fix mypy
doosuu
doosuu requested changes Sep 12, 2023
View reviewed changes
Copy link
Member

@doosuu doosuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add an integration test?

.devcontainer/scripts/post-create.sh Outdated Show resolved Hide resolved
.devcontainer/scripts/post-create.sh Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
desired_state_generator/src/gen_desired_state.py Show resolved Hide resolved
desired_state_generator/src/gen_desired_state.py Outdated Show resolved Hide resolved
runtime_k3d/test/requirements.txt Outdated Show resolved Hide resolved
runtime_kanto/src/install_deps.py Outdated Show resolved Hide resolved
runtime_local/src/install_deps.py Outdated Show resolved Hide resolved
setup.cfg Show resolved Hide resolved
desired_state_generator/src/gen_desired_state.py Outdated Show resolved Hide resolved
@MP91 MP91 requested a review from doosuu September 13, 2023 09:04
doosuu
doosuu requested changes Sep 14, 2023
View reviewed changes
desired_state_generator/src/gen_desired_state.py Outdated Show resolved Hide resolved
desired_state_generator/src/gen_desired_state.py Outdated Show resolved Hide resolved
desired_state_generator/src/gen_desired_state.py Outdated Show resolved Hide resolved
desired_state_generator/src/gen_desired_state.py Outdated Show resolved Hide resolved
desired_state_generator/src/gen_desired_state.py Outdated Show resolved Hide resolved
desired_state_generator/src/gen_desired_state.py Outdated Show resolved Hide resolved
desired_state_generator/src/gen_desired_state.py Outdated Show resolved Hide resolved
desired_state_generator/src/gen_desired_state.py Outdated Show resolved Hide resolved
doosuu
doosuu approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@doosuu doosuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MP91 MP91 merged commit 88d5aa0 into main Sep 14, 2023
6 checks passed
@MP91 MP91 deleted the pantaris-integration branch September 14, 2023 12:42
mml5bg pushed a commit that referenced this pull request Sep 18, 2023
@MP91 @mml5bg
Pantaris integration (#39)
d075a60 
* add desired state generator

- rename packages to fix mypy

* fix review findings

* set mockfilepath in code

* fix review findings

* fix constants

* align constant

* fix access
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doosuu doosuu doosuu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MP91 @doosuu