Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix license-header and pre-commit #53

Merged
merged 3 commits into from
Dec 6, 2023
Merged

Fix license-header and pre-commit #53

merged 3 commits into from
Dec 6, 2023

Conversation

kse3hi
Copy link
Contributor

@kse3hi kse3hi commented Nov 23, 2023

ADO#17300

Copy link

github-actions bot commented Nov 23, 2023

File Coverage Lines Branches
All files 20% 26% 14%
desired_state_generator/src/gen_desired_state.py 36% 41% 32%
runtime_k3d/src/app_deployment/build_vehicleapp.py 0% 0% 0%
runtime_k3d/src/app_deployment/deploy_vehicleapp.py 0% 0% 0%
runtime_k3d/src/runtime/controlplane.py 0% 0% 0%
runtime_k3d/src/runtime/runtime-down.py 0% 0% 0%
runtime_k3d/src/runtime/runtime-up.py 0% 0% 0%
runtime_k3d/src/runtime/runtime.py 0% 0% 0%
runtime_k3d/src/runtime/deployment/gen_helm.py 29% 39% 19%
runtime_k3d/src/runtime/deployment/gen_podspec.py 44% 54% 35%
runtime_k3d/src/runtime/deployment/lib.py 93% 87% 100%
runtime_kanto/src/app_deployment/build_vehicleapp.py 0% 0% 0%
runtime_kanto/src/app_deployment/deploy_vehicleapp.py 0% 0% 0%
runtime_kanto/src/runtime/controlplane_kanto.py 0% 0% 0%
runtime_kanto/src/runtime/runtime_down.py 0% 0% 0%
runtime_kanto/src/runtime/runtime_kanto.py 0% 0% 0%
runtime_kanto/src/runtime/runtime_up.py 0% 0% 0%
runtime_local/src/local_lib.py 22% 22% 0%
runtime_local/src/run-dapr-sidecar.py 0% 0% 0%
runtime_local/src/run-vehicle-app.py 0% 0% 0%
runtime_local/src/run_service.py 30% 42% 18%
runtime_local/src/runtime-up.py 0% 0% 0%

Minimum allowed coverage is 80%

Generated by 🐒 cobertura-action against 57e63d5

MP91
MP91 previously requested changes Nov 24, 2023
Copy link
Contributor

@MP91 MP91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I'm not sure how to handle this but Microsoft did not really contribute to this repo since we created it when the cooperation already ended. Nevertheless some of the files have their origin in the template repo so, microsoft did contribute to SOME files, but I don't exactly know which ones.

NOTICE.md Outdated Show resolved Hide resolved
@kse3hi kse3hi requested a review from MP91 November 24, 2023 21:22
Copy link
Member

@BjoernAtBosch BjoernAtBosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just fixing of .gitignore and corresponding pre-commit stuff required

NOTICE.md Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
Copy link
Member

@BjoernAtBosch BjoernAtBosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kse3hi kse3hi requested review from MP91 and removed request for MP91 December 6, 2023 10:10
@kse3hi kse3hi dismissed MP91’s stale review December 6, 2023 10:13

Was discussed and approved to have MS here

@kse3hi kse3hi merged commit fe2a216 into main Dec 6, 2023
8 checks passed
@kse3hi kse3hi deleted the fix/license_headers branch December 6, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants