Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix src for desired state #75

Conversation

lukasmittag
Copy link
Contributor

@lukasmittag lukasmittag commented Jun 4, 2024

This tries to fix that the src for the vss file is correct in the desired state generation of the release workflow for velocitas. If you would put something like ./velocitas.json in the appManifest.json it will not work before this fix.

@erikbosch
Copy link
Contributor

Linter complains

Copy link
Contributor

@erikbosch erikbosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not tested, but it looks good to me.

Copy link
Contributor

@dennismeister93 dennismeister93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dennismeister93 dennismeister93 merged commit eca67b9 into eclipse-velocitas:main Jun 27, 2024
6 checks passed
@dennismeister93 dennismeister93 deleted the fix/desired_state_src branch June 27, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants