Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate mock service #174

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Integrate mock service #174

merged 1 commit into from
Jul 26, 2023

Conversation

doosuu
Copy link
Member

@doosuu doosuu commented Jul 25, 2023

Description

This PR upgrades the devenv-runtimes package to include the new mock service as default service. This replaces seat-service and feedercan as default services.

Issue ticket number and link

ADO_15873

Checklist

  • Vehicle App can be started with dapr run and is connecting to vehicle data broker

  • Vehicle App can process MQTT messages and call the seat service

  • Vehicle App can be deployed to local K3D and is running

  • Created/updated tests, if necessary. Code Coverage percentage on new code shall be >= 70%.

  • Extended the documentation in Velocitas repo

  • Extended the documentation in README.md

  • Devcontainer can be opened successfully

  • Devcontainer can be opened successfully behind a corporate proxy

  • Devcontainer can be re-built successfully

  • Release workflow is passing

@kse3hi kse3hi self-requested a review July 25, 2023 06:09
kse3hi

This comment was marked as outdated.

@kse3hi kse3hi self-requested a review July 25, 2023 06:10
Copy link
Contributor

@kse3hi kse3hi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have a look on integration tests

@kse3hi kse3hi self-requested a review July 26, 2023 05:40
Copy link
Contributor

@kse3hi kse3hi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kse3hi kse3hi merged commit 4cd41bd into main Jul 26, 2023
7 checks passed
@kse3hi kse3hi deleted the mockservice-integration branch July 26, 2023 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants