Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ros2cli full support #72

Open
MarcoMagriDev opened this issue Jan 30, 2024 · 1 comment
Open

ros2cli full support #72

MarcoMagriDev opened this issue Jan 30, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@MarcoMagriDev
Copy link

Describe the feature

Is your feature request related to a problem?
I have successfully set up a communication between two ROS2 systems via zenoh-bridge-ros2dds. I can see correctly topics, services and actions using the corresponding ros2cli commands. The problem is that when i try to run cli parameters command (i.e. ros2 param dump /my_node) the cli respond Node not found. I think that this is due to the fact that the cli command checks for the node in the graph before trying to contact the corresponding parameter service, unfortunately the node /my_node is not available on both side but only on the side that creates it making the ros2 parameters cli unusable with this bridge.

Describe the solution you'd like
ros2 node list works as expected by reporting all nodes of both sides

Additional context
Note that before the release of this ROS2 specific bridge i was using the generic zenoh-bridge-dds and i never faced this issue (ros2 node list returns all node names not only the bridge node). The motivation for me to use this rather than the generic bridge is that with this version this issue is solved.

@JEnoch
Copy link
Member

JEnoch commented Feb 2, 2024

It was a deliberate choice for the first implementation to expose only 1 zenoh_bridge_ros2dds Node in place of all the remote Nodes this bridge is serving. My fear is that in a system with tens of robots, each with thousands of Nodes, the ROS graph within a fleet manager host would be overwhelmed with >10000 Nodes.

I didn't saw come this drawback with parameters since those are implemented on top of ROS 2 Services which are well supported by the bridge. However, it seems the ROS API for parameters requires to discover the Node from ROS graph before querying those services.

I'created #79 to address the exposure of Nodes by the bridge in remote system. I'll make sure the parameters are well supported once in place.

@JEnoch JEnoch added the enhancement New feature or request label Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants