fix: master node distributes large file upload requests causing OOM

eclipse · Oct 30, 2024 · 718a78f · 718a78f
1 parent feb93c9
commit 718a78f
Showing 1 changed file with 4 additions and 8 deletions.
diff --git a/server/src/main/java/org/eclipse/jifa/server/service/impl/WorkerServiceImpl.java b/server/src/main/java/org/eclipse/jifa/server/service/impl/WorkerServiceImpl.java
@@ -211,14 +211,10 @@ public FileLocation decideLocationForNewFile(UserEntity user, FileType type) {
     @Override
     public long forwardUploadRequestToStaticWorker(StaticWorkerEntity worker, FileType type, MultipartFile file) throws Throwable {
         MultipartBodyBuilder builder = new MultipartBodyBuilder();
-        try {
-            builder.part("file", new ByteArrayResource(file.getBytes()))
-                   .filename(file.getOriginalFilename() != null ? file.getOriginalFilename() : Constant.DEFAULT_FILENAME)
-                   .contentType(MediaType.APPLICATION_OCTET_STREAM);
-            builder.part("type", type.name());
-        } catch (IOException e) {
-            throw new RuntimeException(e);
-        }
+        builder.part("file", file.getResource())
+               .filename(file.getOriginalFilename() != null ? file.getOriginalFilename() : Constant.DEFAULT_FILENAME)
+               .contentType(MediaType.APPLICATION_OCTET_STREAM);
+        builder.part("type", type.name());
 
         UriBuilder uriBuilder = new DefaultUriBuilderFactory().builder()
                                                               .scheme("http")