Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ref inter dependencies cleanup #4017

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

dseurotech
Copy link
Contributor

@dseurotech dseurotech commented Apr 11, 2024

This PR intends to clean up the internal dependencies between kapua modules. In most cases, it just cleans up the pom.xml files from dependencies which are already received transitively via maven (e.g.: if you already depend on the -internal module, it is implicit the dependence from the -api module).
In a few cases data classes have been moved closer to the project that use them -e.g.: IsJobRunningMultipleResponse.java is specific to the job engine and does not need to be in the commons-rest-model module.

@dseurotech dseurotech force-pushed the ref-inter_dependencies_cleanup branch 2 times, most recently from ff38722 to e38ea3b Compare April 16, 2024 10:16
@dseurotech dseurotech force-pushed the ref-inter_dependencies_cleanup branch from e38ea3b to 0edb7bc Compare May 10, 2024 14:37
@codecov-commenter
Copy link

codecov-commenter commented May 10, 2024

Codecov Report

Attention: Patch coverage is 23.28767% with 56 lines in your changes missing coverage. Please review.

Project coverage is 16.80%. Comparing base (296efcd) to head (5622379).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #4017   +/-   ##
==========================================
  Coverage      16.79%   16.80%           
  Complexity        22       22           
==========================================
  Files           2008     2007    -1     
  Lines          52210    52190   -20     
  Branches        4399     4395    -4     
==========================================
  Hits            8770     8770           
+ Misses         43044    43022   -22     
- Partials         396      398    +2     
Files Coverage Δ
...clipse/kapua/client/security/bean/AuthContext.java 0.00% <ø> (ø)
...se/kapua/commons/jpa/KapuaEntityJpaRepository.java 7.08% <ø> (ø)
...umer/lifecycle/listener/DeviceMessageListener.java 0.00% <ø> (ø)
...apua/service/camel/converter/KapuaCamelFilter.java 0.00% <ø> (ø)
...thorization/access/shiro/GroupQueryHelperImpl.java 16.12% <ø> (ø)
.../org/eclipse/kapua/kura/simulator/topic/Topic.java 17.58% <ø> (ø)
...rvice/account/xml/AccountParentPathXmlAdapter.java 90.90% <89.47%> (-9.10%) ⬇️
...pse/kapua/commons/service/internal/ServiceDAO.java 0.00% <0.00%> (ø)

@dseurotech dseurotech force-pushed the ref-inter_dependencies_cleanup branch 8 times, most recently from 40b9b0f to 8b30561 Compare May 21, 2024 07:11
@dseurotech dseurotech force-pushed the ref-inter_dependencies_cleanup branch 6 times, most recently from 6d26658 to f62ac3e Compare June 11, 2024 08:00
@dseurotech dseurotech marked this pull request as ready for review June 12, 2024 06:51
@dseurotech dseurotech force-pushed the ref-inter_dependencies_cleanup branch 2 times, most recently from 3638490 to 130bb96 Compare June 19, 2024 15:30
Signed-off-by: dseurotech <davide.salvador@eurotech.com>
Signed-off-by: dseurotech <davide.salvador@eurotech.com>
…if activated it failed compilation without any debug information

Signed-off-by: dseurotech <davide.salvador@eurotech.com>
Signed-off-by: dseurotech <davide.salvador@eurotech.com>
@dseurotech dseurotech force-pushed the ref-inter_dependencies_cleanup branch from 130bb96 to 5622379 Compare July 3, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants