Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for loosing focus when entering linked mode (rename element) #3245 #3246

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mehmet-karaman
Copy link
Contributor

@mehmet-karaman mehmet-karaman commented Nov 19, 2024

This patch fixes the issue when the user is entering the linked editing mode and looses the focus (happens because of showing up the popup dialog).

Copy link

Test Results

  6 456 files    6 456 suites   3h 12m 18s ⏱️
 43 242 tests  42 649 ✅   584 💤  4 ❌  5 🔥
170 289 runs  167 869 ✅ 2 355 💤 35 ❌ 30 🔥

For more details on these failures and errors, see this check.

Results for commit 9f533cc.

@LorenzoBettini
Copy link
Contributor

@mehmet-karaman there are test failures related to refactoring in the Windows CI build.
I can try to restart the job and see if it was just a flaky test.
But where have you manually tested your solution?

@LorenzoBettini LorenzoBettini added this to the Release_2.38 milestone Nov 19, 2024
@LorenzoBettini
Copy link
Contributor

@cdietrich @szarnekow besides the failing test in Windows, which I relaunched, I can confirm the bug and I can confirm that the solution of @mehmet-karaman works and solves the problem!

@mehmet-karaman
Copy link
Contributor Author

mehmet-karaman commented Nov 20, 2024

I've tested it on Linux (RedHat 9) machine.

@LorenzoBettini
Copy link
Contributor

@mehmet-karaman indeed on the second run the tests succeeded in Windows as well

@mehmet-karaman
Copy link
Contributor Author

@LorenzoBettini Thank you. I hope the code is also ok and it can be merged soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants