Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/auto fill recipe #98

Merged
merged 4 commits into from
Jul 5, 2024
Merged

feat/auto fill recipe #98

merged 4 commits into from
Jul 5, 2024

Conversation

Kelwan
Copy link
Contributor

@Kelwan Kelwan commented Jul 5, 2024

  • feat: fill in recipe automatically
  • chore: remove all refences to runtime builder convention

@Kelwan Kelwan changed the base branch from release to develop July 5, 2024 21:39
Copy link
Member

@zaucy zaucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im not sure how this is working

it's probably because the default is the only option so when you were testing it only looked like it was working. try removing the default while testing or add multiple recipes to the installed recipe folder so you can test selecting between them

Editor/EcsactSdk.cs Outdated Show resolved Hide resolved
Editor/EcsactSdk.cs Outdated Show resolved Hide resolved
Copy link

cocogitto-bot bot commented Jul 5, 2024

✔️ 172fa0e...864d511 - Conventional commits check succeeded.

Copy link
Member

@zaucy zaucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good - don't forget to change PR title

@Kelwan Kelwan merged commit 47cbbd0 into develop Jul 5, 2024
2 checks passed
@Kelwan Kelwan deleted the feat/auto-fill-recipe branch July 5, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants