Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set sb3_imitation.py to CPU to fix error with CUDA #196

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

Ivan-267
Copy link
Collaborator

@Ivan-267 Ivan-267 commented Jul 11, 2024

Set device to CPU as a temporary fix for CUDA users.

Thanks to @MichaelrMentele for reporting this issue and testing the solution.

Relevant PR to track (thanks to @JayRothenberger for finding it):
HumanCompatibleAI/imitation#831

Set device to CPU.
@Ivan-267 Ivan-267 requested a review from edbeeching July 11, 2024 03:04
Copy link
Owner

@edbeeching edbeeching left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no problem with this temporary fix, but I am not sure if I fully understand the underlying issue.

@Ivan-267
Copy link
Collaborator Author

@edbeeching

In short:
Running the script with CUDA setup returned an error, and this PR should make the script functional for everyone (on CPU) until the issue is resolved. There's some data in the linked PR for tracking the issue.

@Ivan-267 Ivan-267 merged commit 931cd28 into main Jul 11, 2024
13 checks passed
@Ivan-267 Ivan-267 deleted the Ivan-267-set-imitation-to-cpu-device branch July 11, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants