Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TPM PCR measurement precalculation #74

Merged
merged 4 commits into from
Jun 10, 2024
Merged

Conversation

msanft
Copy link
Contributor

@msanft msanft commented Jun 5, 2024

This adds the uplosi precalculate-measurements command for ahead-of-time calculation of TPM PCR measurements from an image.

Precalculation code is based on what we have in Constellation right now, with slight modifications to make it work for both Constellation and Continuum images.

It's not documented yet, but also not hidden. I wasn't exactly sure how to go about this.

Signed-off-by: Moritz Sanft <58110325+msanft@users.noreply.github.com>
@msanft msanft force-pushed the feat/tpm-pcr-precalculation branch from 3a99b73 to 432825c Compare June 5, 2024 11:04
Copy link
Member

@daniel-weisse daniel-weisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once this is merged and a new release is cut, we can remove the measurement code from the Constellation repo and use this tool instead, correct?

precalculate-measurements.go Outdated Show resolved Hide resolved
measured-boot/measure/pcr09.go Outdated Show resolved Hide resolved
precalculate-measurements.go Outdated Show resolved Hide resolved
Copy link
Member

@daniel-weisse daniel-weisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please let @katexochen also review before merging

measured-boot/extract/extract.go Outdated Show resolved Hide resolved
measured-boot/extract/extract.go Show resolved Hide resolved
measured-boot/extract/extract_test.go Outdated Show resolved Hide resolved
measured-boot/measure/measure_test.go Outdated Show resolved Hide resolved
measurements.go Show resolved Hide resolved
measurements.go Show resolved Hide resolved
@msanft msanft requested a review from katexochen June 10, 2024 07:06
README.md Outdated Show resolved Hide resolved
Signed-off-by: Moritz Sanft <58110325+msanft@users.noreply.github.com>
@msanft msanft force-pushed the feat/tpm-pcr-precalculation branch from a297fb1 to 3a9a225 Compare June 10, 2024 07:15
@msanft msanft merged commit b7edeef into main Jun 10, 2024
8 checks passed
@msanft msanft deleted the feat/tpm-pcr-precalculation branch June 10, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants