Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add core-metadata device service related db methods for postgres #4913

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

jinlinGuan
Copy link
Contributor

related #4909

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 191 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@39fb801). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...rnal/pkg/infrastructure/postgres/device_service.go 0.00% 112 Missing ⚠️
internal/pkg/infrastructure/postgres/device.go 0.00% 28 Missing ⚠️
...rnal/pkg/infrastructure/postgres/device_profile.go 0.00% 28 Missing ⚠️
...al/pkg/infrastructure/postgres/provisionwatcher.go 0.00% 22 Missing ⚠️
...nternal/pkg/infrastructure/redis/intervalaction.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4913   +/-   ##
=======================================
  Coverage        ?   36.46%           
=======================================
  Files           ?      128           
  Lines           ?    12432           
  Branches        ?        0           
=======================================
  Hits            ?     4533           
  Misses          ?     7505           
  Partials        ?      394           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jinlinGuan jinlinGuan marked this pull request as draft September 13, 2024 07:07
@jinlinGuan jinlinGuan force-pushed the issue-4909 branch 2 times, most recently from 76daa36 to 90fff11 Compare September 20, 2024 10:04
@jinlinGuan jinlinGuan marked this pull request as ready for review September 20, 2024 10:13
cmd/core-metadata/Dockerfile Outdated Show resolved Hide resolved
internal/pkg/infrastructure/postgres/device_profile.go Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Sep 23, 2024

Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8 cloudxxx8 merged commit e4150c7 into edgexfoundry:main Sep 23, 2024
6 checks passed
@jinlinGuan jinlinGuan deleted the issue-4909 branch September 23, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants