Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Return 404 response for Keeper GET key API with Postgres #4918

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

lindseysimple
Copy link
Contributor

@lindseysimple lindseysimple commented Sep 18, 2024

Relates to #4877. Return 404 response for Keeper GET key API with Postgres. Copy res/db dir in Keeper Docker file.

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

Relates to edgexfoundry#4877. Return 404 response for Keeper GET key API with Postgres.
Copy res/db dir in Keeper Docker file.

Signed-off-by: Lindsey Cheng <beckysocute@gmail.com>
Copy link

sonarcloud bot commented Sep 18, 2024

Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 36.91%. Comparing base (06bbb4e) to head (52b499c).

Files with missing lines Patch % Lines
internal/pkg/infrastructure/postgres/kv.go 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4918      +/-   ##
==========================================
- Coverage   36.92%   36.91%   -0.01%     
==========================================
  Files         125      125              
  Lines       12276    12278       +2     
==========================================
  Hits         4533     4533              
- Misses       7349     7351       +2     
  Partials      394      394              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cloudxxx8 cloudxxx8 merged commit 01f2b53 into edgexfoundry:main Sep 18, 2024
6 checks passed
@cloudxxx8 cloudxxx8 deleted the issue-4877-3 branch September 18, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants