Allow multiple groups in pb-login #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daliboris
changed the title
wolfgangmm
reviewed
Nov 27, 2023
src/pb-login.js
Outdated
| _checkGroup(info) { | ||
| if (this.group) { | ||
| return info.groups && info.groups.indexOf(this.group) > -1; | ||
| let groupArray = this.group.split(/\W+/); |
There was a problem hiding this comment.
Using any punctuation would not allow valid group names like tei-demo or similar. Maybe limit it to whitespace or comma?
…is/tei-publisher-components into feature/pb-login-multiple-groups
|
Yes, thank you. I prefer a space and a comma because the value of the The warning message looks like a natural sentence if the groups are separated by a comma followed by a space. |
|
🎉 This PR is included in version 2.15.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation allows only one group to be specified in
pb-logincomponent.This change allows multple groups in pb-login, for example
teiandquest.Groups are separated items by space and/or punctuation.
This change doesn't break existing implementations.