add highlight modification #172
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed a highlight with stripes (to highlight witnesses in a webapp with a critical apparatus), similar to the one which is used with the annotation interface. In my use case, a witness is associated with 2 categories, represented by 2 different colors, hence the need for stripes combining the same 2 colors.
Gradients css can produce that easily, but they need a "background-image" property.
I just added a property to the component
--pb-highlight-background-imageto be exposed in the api.I added a demo which shows a highlighight with stripes.
PS. I also modified the @cssprop for the initial --pb-highlight-color to indicate the color code of the default color (
#F9E976).