Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change of width in pb-collapase icons #179

Merged
merged 1 commit into from
Jul 23, 2024
Merged

change of width in pb-collapase icons #179

merged 1 commit into from
Jul 23, 2024

Conversation

HelenaSabel
Copy link
Contributor

The use of display:flex in the <pb-collapse> #trigger was causing readjustments of the size of the icons. See:

image

This PR proposes using grid instead of flex to avoid these changes.

JoernT
JoernT approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@JoernT JoernT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixing actually fixes the icon rendering issues

@JoernT JoernT merged commit 8ea90c5 into master Jul 23, 2024
1 check passed
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 2.24.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoernT JoernT JoernT approved these changes

@wolfgangmm wolfgangmm Awaiting requested review from wolfgangmm

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HelenaSabel @JoernT