-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align file extensions with documentation #9
base: master
Are you sure you want to change the base?
Conversation
The user documentation at https://eeditiones.github.io/tuttle-doc/getstarted/configuration/ states: > Tuttle is configured in modules/config.xqm in your Tuttle installation. This changes modules/config.xql to conform with the documentation’s filename. In the process, it applies the community file extensions to all XQuery modules in the repository - namely, .xq for main modules, and .xqm for library modules. It adjusts module prologs to use the updated location hints for module imports. Also, for consistency, it adds newlines to modules that lack them.
I meant to note that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@joewiz for my local testing I
I agree that this should be documented in the readme under "Testing" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good. Needs a rebase after #22 has been merged
@joewiz in the meantime I did a bigger rework of tuttle and now your changes are conflicting I am sorry for causing you extra work. I think we should change the endings as you proposed. |
The user documentation at https://eeditiones.github.io/tuttle-doc/getstarted/configuration/ states:
This PR changes
modules/config.xql
to conform with the filename in the documentation.In the process, it applies the eXist-db (and BaseX) community file extensions to all XQuery modules in the repository - namely,
.xq
for main modules, and.xqm
for library modules.It adjusts module prologs to use the updated location hints for module imports.
Also, for consistency, it adds newlines to modules that lack them.