Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix .tcl server add/remove arg parsing #1722

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix .tcl server add/remove arg parsing #1722

wants to merge 2 commits into from

Conversation

michaelortmann
Copy link
Member

@michaelortmann michaelortmann commented Dec 18, 2024 •
edited
Loading

Found by: DasBrain
Patch by: michaelortmann
Fixes: #1721

One-line summary:

Additional description (if needed):
Before:
.tcl server add/remove -> crash
After:

.tcl server add
Tcl error: wrong # args: should be "server add host ?port? ?password?"
.tcl server remove
Tcl error: wrong # args: should be "server remove host ?port? ?password?"

DasBrain
DasBrain reviewed Dec 18, 2024
View reviewed changes
src/mod/server.mod/tclserv.c Outdated Show resolved Hide resolved
src/mod/server.mod/tclserv.c Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DasBrain DasBrain DasBrain left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

.tcl server add crashes eggdrop
2 participants
@michaelortmann @DasBrain