Add serialization support #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saulshanabrook
commented
Jul 18, 2023
Comment on lines
+61
to
+67
| /// Return the inner values and sorts. | ||
| /// Only eq_container_sort need to implement this method, | ||
| fn inner_values(&self, value: &Value) -> Vec<(&ArcSort, Value)> { | ||
| let _ = value; | ||
| vec![] | ||
| } | ||
|
|
There was a problem hiding this comment.
I added this so that we can properly handle e-classes inside of collections. If we just use extract (what I tried previously) then it will only give us a particular e-node from a collection, instead of referencing the full e-class. So instead provide a native way to traverse the inner values.
|
While there are definitely some benefits to snapshot testing, I'm not ready to commit to it with this PR. Can you please back it out for now? Otherwise the PR looks great! |
|
Thanks! Sure, I just removed the tests. |
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds serialization support to the
egraph-serializeformat.It pulls some ideas and code from the viz pr (#147) around requirements for the serialization format.
I also started using the insta library for snapshot testing, to verify that certain examples are serialized properly. So far, I just tried to manually look over them to make sure they seem sensible.
Once the viz work is redone on top of this, it will also be easier to quickly verify the results.
The choice of how to determine the node IDs is not the most straightforward one, but conforms to certain properties that were useful for the graphviz work, which would use these directly (since in graphviz you can't actually point to a cluster, you have to point to nodes).
Link to some relevant convo on zulip around how to serialize.