-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rebuilding and extraction bugs for EqSort containers #191
Conversation
Looks like this is still in progress. Converted to draft. |
@mwillsey It should be ready for review now. The last time I pushed the tests are passing locally but not in CI. The bug should now be fixed. |
There seem to be conflicts. Can you merge main into this branch? |
@mwillsey done |
Good changes! |
Maybe we should add stronger extraction tests in the future, for example at least checking that the cost stayed the same. But for now good work! We should merge this |
This small PR should fix #165. There might be other bugs (especially memory leaks) with containers.
Update: this PR also contains some other fixes and changes.
Sort
trait.