Fix rebuilding and extraction bugs for EqSort containers #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this is still in progress. Converted to draft. |
|
@mwillsey It should be ready for review now. The last time I pushed the tests are passing locally but not in CI. The bug should now be fixed. |
|
There seem to be conflicts. Can you merge main into this branch? |
yihozhang
changed the title
|
@mwillsey done |
|
Good changes! |
|
Maybe we should add stronger extraction tests in the future, for example at least checking that the cost stayed the same. But for now good work! We should merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small PR should fix #165. There might be other bugs (especially memory leaks) with containers.
Update: this PR also contains some other fixes and changes.
Sorttrait.