Serialized Class ID <-> Value #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You're a lifesaver!! Just to be clear: there's a lot of things I have to do over a serialized egraph, because I can't inspect the egglog::EGraph enough to do what I need. I realize that egglog is different from egg, and that this is one of the results. I'm just trying to say that my use of the serialized egraph is mostly just a hack around the core problem of not being able to inspect the egglog::EGraph. Either way, Saul's PR helps my hack be less hacky :) |
|
I think having the serialized e-graph as a public API maybe isn't the worst, it at least makes it easy to change the internals of egglog without disrupting the API at all. |
saulshanabrook
commented
Jul 25, 2024
saulshanabrook
commented
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #392 to add a public API for going from serialized Class IDs to Values.
It does this by changing the serialized class IDs to be more uniform. It should preserve all behavior.
cc @gussmith23