Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiset after Value.tag #454

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

Alex-Fischman
Copy link
Contributor

The Value.tag PR passed CI when it shouldn't have. This PR fixes the compiler error currently on main.

@Alex-Fischman Alex-Fischman requested a review from a team as a code owner October 28, 2024 16:09
@Alex-Fischman Alex-Fischman requested review from ajpal, saulshanabrook, oflatt and yihozhang and removed request for a team, ajpal and oflatt October 28, 2024 16:09
Copy link

codspeed-hq bot commented Oct 28, 2024

CodSpeed Performance Report

Merging #454 will improve performances by 14.08%

Comparing Alex-Fischman:fix-multiset (d7536ad) with main (993582f)

Summary

⚡ 3 improvements
✅ 5 untouched benchmarks

Benchmarks breakdown

Benchmark main Alex-Fischman:fix-multiset Change
cykjson 343.2 ms 320.1 ms +7.23%
eggcc-extraction 4.3 s 4.1 s +5.09%
math-microbenchmark 4.1 s 3.6 s +14.08%

@Alex-Fischman
Copy link
Contributor Author

(CodSpeed is just showing the same speedup as on Value.tag.)

@saulshanabrook saulshanabrook merged commit 1f4603a into egraphs-good:main Oct 28, 2024
5 checks passed
@Alex-Fischman Alex-Fischman deleted the fix-multiset branch October 28, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants