Skip to content

Commit

Permalink
[Response Ops][Task Manager] Deprecating `xpack.task_manager.claim_st…
Browse files Browse the repository at this point in the history
…rategy` config (#203341)

Resolves #202492

## Summary

For 9.0 only. Deprecates `xpack.task_manager.claim_strategy`
configuration. Logs warning if value is explicitly set. This value was
never added to the Kibana docs in
`docs/settings/task-manager-settings.asciidoc` so nothing to remove
there.

## To Verify

Set `xpack.task_manager.claim_strategy` config in `kibana.dev.yml` and
start Kibana. See warning get logged.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
  • Loading branch information
ymao1 and elasticmachine authored Dec 12, 2024
1 parent b74b935 commit 10771a1
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions x-pack/plugins/task_manager/server/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,10 @@ export const config: PluginConfigDescriptor<TaskManagerConfig> = {
level: 'warning',
message: `Configuring "xpack.task_manager.max_workers" is deprecated and will be removed in a future version. Remove this setting and use "xpack.task_manager.capacity" instead.`,
}),
deprecate('claim_strategy', 'a future version', {
level: 'warning',
message: `Configuring "xpack.task_manager.claim_strategy" is deprecated and will be removed in a future version. This setting should be removed.`,
}),
(settings, fromPath, addDeprecation) => {
const taskManager = get(settings, fromPath);
if (taskManager?.index) {
Expand Down

0 comments on commit 10771a1

Please sign in to comment.