Skip to content

Commit

Permalink
[8.x] [ML] Data frame analytics: Adds missing space between lines in …
Browse files Browse the repository at this point in the history
…delete job modal (#204732) (#204967)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ML] Data frame analytics: Adds missing space between lines in delete
job modal (#204732)](#204732)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Robert
Jaszczurek","email":"92210485+rbrtj@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-12-19T15:35:37Z","message":"[ML]
Data frame analytics: Adds missing space between lines in delete job
modal (#204732)\n\nFix for:
[#204598](https://github.com/elastic/kibana/issues/204598)\n\nAfter:\n\n<img
width=\"995\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/4c5404af-aa0d-4860-beb9-0ada9312f125\"\n/>","sha":"b50bec8f2399e50a7647872897b327fe5139c052","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix",":ml","v9.0.0","Team:ML","backport:version","v8.18.0"],"title":"[ML]
Data frame analytics: Adds missing space between lines in delete job
modal","number":204732,"url":"https://github.com/elastic/kibana/pull/204732","mergeCommit":{"message":"[ML]
Data frame analytics: Adds missing space between lines in delete job
modal (#204732)\n\nFix for:
[#204598](https://github.com/elastic/kibana/issues/204598)\n\nAfter:\n\n<img
width=\"995\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/4c5404af-aa0d-4860-beb9-0ada9312f125\"\n/>","sha":"b50bec8f2399e50a7647872897b327fe5139c052"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204732","number":204732,"mergeCommit":{"message":"[ML]
Data frame analytics: Adds missing space between lines in delete job
modal (#204732)\n\nFix for:
[#204598](https://github.com/elastic/kibana/issues/204598)\n\nAfter:\n\n<img
width=\"995\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/4c5404af-aa0d-4860-beb9-0ada9312f125\"\n/>","sha":"b50bec8f2399e50a7647872897b327fe5139c052"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Robert Jaszczurek <92210485+rbrtj@users.noreply.github.com>
  • Loading branch information
kibanamachine and rbrtj authored Dec 19, 2024
1 parent 0096008 commit abf4a5f
Showing 1 changed file with 17 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import {
EuiFlexGroup,
EuiFlexItem,
EUI_MODAL_CONFIRM_BUTTON,
EuiSpacer,
} from '@elastic/eui';

import type { DeleteAction } from './use_delete_action';
Expand Down Expand Up @@ -79,16 +80,22 @@ export const DeleteActionModal: FC<DeleteAction> = ({
</EuiFlexItem>
<EuiFlexItem>
{userCanDeleteIndex && dataViewExists && (
<EuiSwitch
data-test-subj="mlAnalyticsJobDeleteDataViewSwitch"
label={i18n.translate('xpack.ml.dataframe.analyticsList.deleteTargetDataViewTitle', {
defaultMessage: 'Delete data view {dataView}',
values: { dataView: indexName },
})}
checked={deleteDataView}
onChange={toggleDeleteDataView}
disabled={userCanDeleteDataView === false}
/>
<>
<EuiSpacer size="s" />
<EuiSwitch
data-test-subj="mlAnalyticsJobDeleteDataViewSwitch"
label={i18n.translate(
'xpack.ml.dataframe.analyticsList.deleteTargetDataViewTitle',
{
defaultMessage: 'Delete data view {dataView}',
values: { dataView: indexName },
}
)}
checked={deleteDataView}
onChange={toggleDeleteDataView}
disabled={userCanDeleteDataView === false}
/>
</>
)}
</EuiFlexItem>
</EuiFlexGroup>
Expand Down

0 comments on commit abf4a5f

Please sign in to comment.